Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'inbounds' display range to geom_football #18

Closed
nguyenank opened this issue Oct 12, 2022 · 3 comments
Closed

Add 'inbounds' display range to geom_football #18

nguyenank opened this issue Oct 12, 2022 · 3 comments
Assignees
Labels
feature request New feature or request

Comments

@nguyenank
Copy link

Add a default display range for football geoms that only displays what's in play.

@rossdrucker rossdrucker self-assigned this Oct 12, 2022
@rossdrucker rossdrucker added the feature request New feature or request label Oct 12, 2022
@rossdrucker
Copy link
Collaborator

I've gone ahead and tried to implement this for all surfaces, not just football. The football-specific result looks like this:

geom_football(
  "nfl",
  "in bounds only"
  color_updates = list(
    "sideline" = "#ff552e",
    "end_line" = "#13294b"
  )
)

Example of in bounds only display range

Note: Colors of sideline and end line changed to make them stand out from background of plot

Is that what you had in mind?

@nguyenank
Copy link
Author

Yep; that's pretty much exactly what I was thinking!

@rossdrucker
Copy link
Collaborator

Closed via #19

rossdrucker added a commit that referenced this issue Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants