Issue 124/schedule endpoint #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be unnested via tidyr::unnest()
…ly deleted while testing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rossdrucker
requested review from
saiemgilani,
billyfryer,
john-b-edwards,
andreweatherman and
papagorgio23
… columns (plucked and combined with bind_cols() so no data lost)
… are added by hoopR in nba_schedule() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe this fixes #124 but would want to double-check the columns returned that should be fixed. This will successfully pull the endpoint, but based on the structure change, the column names/orders may be rearranged