Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several bugs in cross-multiplication implementation #2123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Fix several bugs in cross-multiplication implementation

771c568
Select commit
Loading
Failed to load commit list.
Open

Fix several bugs in cross-multiplication implementation #2123

Fix several bugs in cross-multiplication implementation
771c568
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 5, 2025 in 0s

81.85% (-0.02%) compared to 15ff926, passed because coverage increased by 0% when compared to adjusted base (81.85%)

View this Pull Request on Codecov

81.85% (-0.02%) compared to 15ff926, passed because coverage increased by 0% when compared to adjusted base (81.85%)

Details

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (15ff926) to head (771c568).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rg/spockframework/runtime/DataIteratorFactory.java 62.50% 1 Missing and 11 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2123      +/-   ##
============================================
- Coverage     81.87%   81.85%   -0.02%     
- Complexity     4687     4688       +1     
============================================
  Files           452      452              
  Lines         14656    14673      +17     
  Branches       1846     1859      +13     
============================================
+ Hits          12000    12011      +11     
+ Misses         1976     1973       -3     
- Partials        680      689       +9     
Files with missing lines Coverage Δ
...rg/spockframework/runtime/DataIteratorFactory.java 79.16% <62.50%> (-1.91%) ⬇️

... and 2 files with indirect coverage changes