Issue with Spock Parallel execution after upgrade to Selenium 4

[SagarK15]

Describe the bug

After upgrade to Selenium 4.13.0 we are facing issue with Geb + spock parallel execution.
We are using Selenium grid deployed through docker for parallel execution.

Geb and Spock Dependencies used:

	spock-junit4 = 2.3-groovy-3.0
	spock-core = 2.3-groovy-3.0
	geb-spock = 6.0

Below is our SpockConfig.groovy file:

runner {

parallel {
    enabled true
    defaultSpecificationExecutionMode ExecutionMode.CONCURRENT
    defaultExecutionMode ExecutionMode.SAME_THREAD
    fixed(5)
}

}

Here if we keep thread count as 5 , ideally spock should send only 5 spec at a time for execution as the defaultSpecificationExecutionMode is concurrent and defaultExecutionMode is SAME_THREAD.But it sends all the spec present in the module and keeps on increasing the Selenium Grid Queue size.

To Reproduce

Start Selenium Distributed grid 4.13.0 through docker compose with 5 chrome nodes.

Execute Geb test cases with Thread count as 2

Expected behavior

It should run 2 spec at a time as the thread count is fixed as 2.

Actual behavior

Its running all the specs at once and increasing the Selenium grid queue size

Java version

1.8.0_241

Buildtool version

Gradle 5.6

What operating system are you using

Windows

Dependencies

dependencies-report.txt

Additional context

No response

[kriegaex]

After upgrade to Selenium 4.13.0 we are facing issue

Does that mean, before the upgrade it used to work as expected? If so, please also specify the previous version which did what you expect.

[Vampire]

What you configure to 5 or 2 is not the "thread count", but the "parallelism".
If a SUT or test for example uses a ForkJoinPool or CompletableFuture with join or similar, that could lead to the behavior you describe.
This is an underlying problem of JUnit Platform tracked at junit-team/junit-framework#3108.
If my suspicion is correct, I also described a work-around for Spock tests at junit-team/junit-framework#3108 (comment) that works properly for me so far.

[SagarK15]

After upgrade to Selenium 4.13.0 we are facing issue

Does that mean, before the upgrade it used to work as expected? If so, please also specify the previous version which did what you expect.

Hello @kriegaex

Yes it used to work as expected with Selenium 3.
Geb : 5.1
Spock : 2.3-groovy-3.0
Selenium : 3.141.59

[SagarK15]

After upgrade to Selenium 4.13.0 we are facing issue

Does that mean, before the upgrade it used to work as expected? If so, please also specify the previous version which did what you expect.

Hey @kriegaex , do we have any update on the problem statement

[Vampire]

Did you try the work-around I suggested? If it works, it is that underlying problem in JUnit platform that should be fixed there I also linked to.

[sagarkundar]

We tried with the workaround mentioned but still facing the same issues.

Can we expect this fix in the upcoming versions of spock.

[Vampire]

If it is not the mentioned JUnit Platform issue, can you provide an MCVE?
Then maybe something can be done about it if it is really a Spock issue.
Needing to set up various systems and a selenium grid to reproduce does not exactly sound like M.

[Vampire]

Closing due to lack of feedback.
If it is the JUnit Platform Issue, there is now a PR in the works that should fix it at junit-team/junit-framework#5060.