Skip to content

Conversation

@l00py
Copy link

@l00py l00py commented Oct 28, 2023

  • Related issue SDK 1.7.4 does not stream all events in one chunk in a distributed search #541
  • Findings
    • Behavior change since 1.6.15 from Fix chunk synchronization #301
    • SearchCommand._execute_v2() writes records as soon as a result from the chunk is processed, rather than capturing a generator of all the records from the chunk, and then writing.
  • Reverting a few logics
    • Reintroduced SearchCommand._records_protocol_v2
  • Remaining action items
    • May need to refactor SearchCommand._records_protocol_v2() to leverage SearchCommand._read_csv_records(), though the reading may need to be processed in a higher layer.
    • May need to refactor SearchCommand._execute_v2(), since it is only used by generating_command.py, as such we may want a common abstract interface for all commands using the v2 protocol.
    • Regression testings

@l00py l00py closed this May 24, 2025
@Ickerday Ickerday deleted the phil/fix_chunk branch September 26, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant