Skip to content

checks added for hec configuration #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

checks added for hec configuration #836

wants to merge 2 commits into from

Conversation

@BigCaber
Copy link

@BigCaber BigCaber commented May 14, 2024

changes

@BigCaber BigCaber requested a review from a team as a code owner May 14, 2024 06:54
@jmeixensperger
Copy link
Contributor

jmeixensperger commented May 14, 2024

Can you please change the order so that the is defined check is performed first? If that var is not defined, the first check will fail to evaluate.

@BigCaber
Copy link
Author

BigCaber commented May 15, 2024

reordered

@BigCaber
Copy link
Author

BigCaber commented May 24, 2024

@jmeixensperger I think you missed my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmeixensperger jmeixensperger jmeixensperger approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BigCaber @jmeixensperger