Skip to content

feat: allow *.xml (beside *.log) files as sample input files #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9 commits merged into from
Feb 28, 2022
Merged

feat: allow *.xml (beside *.log) files as sample input files #550

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b2b3596
feat: allow *.xml (beside *.log) files as sample input files
hsekowski-splunk Feb 18, 2022
3ccf59c
chore: to test the project unit tests
hsekowski-splunk Feb 18, 2022
85717f6
fix: unit test addopted to the change
hsekowski-splunk Feb 18, 2022
85226b4
fix: fake_path corrected for xml sample
hsekowski-splunk Feb 18, 2022
0147b5e
fix: ingestion extended by *.xml files
hsekowski-splunk Feb 21, 2022
5ffe040
chore: updated error msg
hsekowski-splunk Feb 21, 2022
c01b8eb
chore: add *.xml file to requirement tests
hsekowski-splunk Feb 28, 2022
e2c3f68
chore: assertion changed to reflect second source of the data that ca…
hsekowski-splunk Feb 28, 2022
6fb6702
chore: assertion updated
hsekowski-splunk Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytest_splunk_addon/standard_lib/requirement_tests/test_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def generate_cim_req_params(self):
for file1 in os.listdir(req_file_path):
filename = os.path.join(req_file_path, file1)
LOGGER.info(filename)
if filename.endswith(".log"):
if filename.endswith(".log") or filename.endswith(".xml"):
try:
self.check_xml_format(filename)
except Exception:
Expand Down
24 changes: 20 additions & 4 deletions tests/unit/tests_standard_lib/test_requirement_tests/test_test_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,27 @@ def test_extract_params():
["requirement.xml"],
[True],
["syslog"],
{"event": ["event_1", "event_2"]},
[["model_1:dataset_1", "model_2:dataset_2"], ["model_3:dataset_3"]],
["event_name_2"],
{"event": ["<34>Oct 11 22:14:15 machine1 pr1:event_1"]},
[["model_1:dataset_1", "model_2:dataset_2"]],
["event_name_1"],
[{"field1": "value1", "field2": "value2"}, {"field3": "value3"}],
[],
[
(
{
"model_list": [
("model_1", "dataset_1", ""),
("model_2", "dataset_2", ""),
],
"escaped_event": "event_1",
"exceptions_dict": {"field3": "value3"},
"Key_value_dict": {"field1": "value1", "field2": "value2"},
"modinput_params": None,
"transport_type": "syslog",
},
"model_1:dataset_1 "
"model_2:dataset_2::fake_path/requirement.xml::event_no::1::event_name::event_name_1",
),
],
),
(
["req.log"],
Expand Down