refactor: clean up helmut after initial refactoring #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
It creates unnecessary complexity by adding this Logging class to every class that wants to implement logging.
uoboda-splunk
previously approved these changes
Feb 17, 2022
ghost
approved these changes
Feb 18, 2022
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of work after #523.
This PR does not change a behaviour of PSA anyhow, it just cleans up the internal helmut library which should not be used by other libraries.
Biggest changes in this PR:
faker's debug log anymore)Each commit represents a single change and the code was tested by running a real test after each commit.
Now, helmut library has only those pieces of the code that we actually need in PSA (query, wait for it's completion and then get results). Of course, it can be refactored further, but it can be done later.