-
Notifications
You must be signed in to change notification settings - Fork 21
feat!: Refactor Basic class for requirement test #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 573 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 143 | 1 | 429 | 0 |
Click to see the invalid file list
- pytest_splunk_addon/standard_lib/addon_requirements_basic.py
388277a to
9708853
Compare
d11872a to
d2d7f62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the changes but I believe this has the effect of being a breaking change existing requirements jobs will fail until they are updated. To keep that from happening this PR needs to you sem-commit and properly indicate breaking so we get a major version. Then we can publish and script the update process into the template rollout so we don't disrupt teams.
d2d7f62 to
d0782b3
Compare
d0782b3 to
252b8f7
Compare
BREAKING CHANGE:TA's tests/requirement_test/pytest.ini file requires update
252b8f7 to
07f7e1b
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes in the PR-