Skip to content

Conversation

@nandinivij
Copy link
Contributor

@nandinivij nandinivij commented Jan 18, 2022

Changes in the PR-

  1. Separate addon_basic class for requirement test, keeping the same test functionality we currently have.
  2. Add splunk_ingest_data fixture to test_requirement_params arguments
  3. For this change we will need to update requirement_test/test_addon.py to -
 from pytest_splunk_addon.standard_lib.addon_requirements_basic import RequirementBasic
        class Test_App(RequirementBasic):
            def empty_method():
                pass

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 573 files.

Valid Invalid Ignored Fixed
143 1 429 0
Click to see the invalid file list
  • pytest_splunk_addon/standard_lib/addon_requirements_basic.py

@nandinivij nandinivij force-pushed the update/addon_basic branch 2 times, most recently from 388277a to 9708853 Compare January 19, 2022 23:33
@nandinivij nandinivij force-pushed the update/addon_basic branch 2 times, most recently from d11872a to d2d7f62 Compare January 20, 2022 18:00
@nandinivij nandinivij marked this pull request as ready for review January 20, 2022 21:49
@nandinivij nandinivij requested review from a user and ryanfaircloth January 20, 2022 21:49
Copy link
Contributor

@ryanfaircloth ryanfaircloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes but I believe this has the effect of being a breaking change existing requirements jobs will fail until they are updated. To keep that from happening this PR needs to you sem-commit and properly indicate breaking so we get a major version. Then we can publish and script the update process into the template rollout so we don't disrupt teams.

BREAKING CHANGE:TA's tests/requirement_test/pytest.ini file requires update
@nandinivij nandinivij changed the title Update/addon basic Refactor Basic class requirement test Jan 21, 2022
@nandinivij nandinivij merged commit 1bfd8b1 into main Jan 21, 2022
@nandinivij nandinivij deleted the update/addon_basic branch January 21, 2022 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants