Skip to content

assert modified Field check plus DM check #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021
Merged

assert modified Field check plus DM check #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions pytest_splunk_addon/standard_lib/requirement_tests/test_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,6 @@ def test_requirement_params(
)
self.logger.info(f"Data model check: {datamodel_check}")
sourcetype = keyValue_dict_SPL["_sourcetype"]
assert datamodel_check, (
f"data model check: {datamodel_check} \n"
f"data model in requirement file {model_datalist}\n "
f"data model extracted by TA {list(datamodel_based_on_tag.keys())}\n"
f"sourcetype of ingested event: {sourcetype} \n"
)
field_extraction_check, missing_key_value = self.compare(
keyValue_dict_SPL, key_values_xml
)
Expand All @@ -188,8 +182,11 @@ def test_requirement_params(
valueInSplunk = keyValue_dict_SPL[key]
mismapped_key_value_pair.update({key: valueInSplunk})

assert field_extraction_check, (
f"Issue with the field extraction.\nsearch={search}\n"
assert datamodel_check and field_extraction_check, (
f" Issue with either field extraction or data model.\nsearch={search}\n"
f" data model check: {datamodel_check} \n"
f" data model in requirement file {model_datalist}\n "
f" data model extracted by TA {list(datamodel_based_on_tag.keys())}\n"
f" Field_extraction_check: {field_extraction_check} \n"
f" Key value not extracted by TA: {missing_key_value} \n"
f" Mismatched key value: {mismapped_key_value_pair}\n"
Expand Down