Skip to content

Conversation

@seanmalloy-crest
Copy link
Contributor

fix: Adding check to fix issue when search includes savedsearch

@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@seanmalloy-crest seanmalloy-crest force-pushed the INFRA-34069-Fix-Nested-SavedSearch-tests branch from aba390e to cccf849 Compare October 5, 2021 01:14
@harshshah2-crest
Copy link
Contributor

@harshshah2-crest harshshah2-crest self-requested a review October 5, 2021 06:10
@seanmalloy-crest seanmalloy-crest force-pushed the INFRA-34069-Fix-Nested-SavedSearch-tests branch from 72f67da to b2f5a5b Compare October 5, 2021 20:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Expected release notes (by @seanmalloy-crest)

fixes:
Adding check to fix issue when search includes savedsearch (b2f5a5b)

others (will not be included in Semantic-Release notes):
16e5a43 refactoring with pre-commit
5a6f29b resolved poetry.lock merge conflicts
05010c7 updated poetry.lock
7bdfb04 added sphinx to dev dependencies in .toml
2af036f removed unused imports
285bfaa spell checking
341d51c refactoring, added inline documentation
7463426 report field names and code refactoring
c1c4b3a implemented new requirements to cim field report generation
4d4a67c added ta meta information section to the report
6eae2bc added to cim fields report code to collect sourcetypes for found sample events
3680baa merged changes for current report version
9ef7d62 max-time argument and reporting file name has been added
90b7482 first checkin for cim-field-report
3adebce resolved poetry.lock merge conflicts
2a56119 assert modified Field check plus DM check
81c4af2 updated poetry.lock
994edb8 added sphinx to dev dependencies in .toml
c6a9cd4 removed unused imports
apply black (980dcda)
add pre-commit CI step, remove other linters (450ceff)
do not include actionlint (df93786)
f9038dd spell checking
ad0ec95 refactoring, added inline documentation
4ec60df report field names and code refactoring
51bcfc2 implemented new requirements to cim field report generation
152738e added ta meta information section to the report
dac9566 added to cim fields report code to collect sourcetypes for found sample events
10a9c75 merged changes for current report version
0cc389f max-time argument and reporting file name has been added
cd8b069 first checkin for cim-field-report

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@seanmalloy-crest seanmalloy-crest marked this pull request as ready for review October 6, 2021 20:38
@seanmalloy-crest seanmalloy-crest merged commit c656266 into main Oct 7, 2021
@seanmalloy-crest seanmalloy-crest deleted the INFRA-34069-Fix-Nested-SavedSearch-tests branch October 7, 2021 04:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.9.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants