refactor: use conf-parser in TagsParser instead of Appinspect #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
refactor/conf-parser-in-tags-parser
branch
from
99eb19e to
73b2bbc
Compare
ghost
requested review from
jayjoshi-crest,
kkania-splunk and
uoboda-splunk
kkania-splunk
approved these changes
Sep 23, 2021
Author
|
@kkania-splunk do you approve? |
Contributor
|
@arys-splunk yes, it's approved |
ghost
force-pushed
the
refactor/conf-parser-in-tags-parser
branch
from
4dd2851 to
ba50469
Compare
|
@arys-splunk Can you fix the conflict, please? |
ghost
force-pushed
the
refactor/conf-parser-in-tags-parser
branch
from
ba50469 to
7d6c7a6
Compare
Author
Done. |
ricardom-splunk
approved these changes
Nov 26, 2021
Contributor
|
🎉 This PR is included in version 1.11.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
splunk-appinspectdependency fromTagsParserin PSA and rewrites tests to remove mocking and use real files to test.There will be more PRs for other
.confparsers after this one.