feat: remove eventgen.conf support #413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siddharthkhatsuriya-crest Feel free to add more people for review. |
ghost
self-requested a review
uoboda-splunk
previously approved these changes
Oct 22, 2021
ghost
force-pushed
the
feature/remove-eventgen
branch
from
d2c2ef2 to
f9a41cd
Compare
ghost
force-pushed
the
feature/remove-eventgen
branch
from
0e866f2 to
14ad5e8
Compare
ghost
force-pushed
the
feature/remove-eventgen
branch
from
14ad5e8 to
2b7b806
Compare
ghost
marked this pull request as draft
|
Expected release notes (by @arys-splunk) features: others (will not be included in Semantic-Release notes):
|
|
Will be implemented in #464 |
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed,
eventgen.confsupport was needed as a transition step, no needed anymore.I did not rename class and everything to something else, but if you have an idea of a good name - please comment!