Customer prs 1 #86
Merged
Customer prs 1 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means a failed container will no longer hang the test command
This is consistent with the validation check that allows no tests if status=experimental
Updated validator for "tests" so that it always runs, even if no tests are provided. without adding always=True, it fails to catch missing tests. Also, ensure that we run against the .value of the enumeration, not the enum object itself. This is required since The Pydantic config use_enum_values = True
Allow absent tests for experimental detections
Update new content generator with new formats
Handle stopped containers in testing
linuxdaemon
suggested changes
Nov 28, 2023
| @@ -177,7 +177,7 @@ def datamodel_valid(cls, v, values): | |||
| return v | |||
|
|
|||
| def all_tests_successful(self) -> bool: | |||
| if len(self.tests) == 0: | |||
| if len(self.tests) == 0 and self.status is DetectionStatus.production.value: | |||
There was a problem hiding this comment.
Suggested change
| if len(self.tests) == 0 and self.status is DetectionStatus.production.value: | |
| if len(self.tests) == 0 and self.status == DetectionStatus.production.value: |
This is something I had to fix in my fork and hadn't circled back to updating the PR
Note that some of these fixes have already been made separately.
|
After merging updates, outstanding change still looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a number of user-contributed PRs.
These PRs have been evaluated individually and approved, but the sum of these changes will be evaluated exhaustively together to ensure everything looks good.
Thanks to @linuxdaemon, especially, for all the contributions!