Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of more bits of SSA #255

Merged
merged 8 commits into from
Sep 13, 2024
Merged

Removal of more bits of SSA #255

merged 8 commits into from
Sep 13, 2024

Conversation

ljstella
Copy link
Contributor

@ljstella ljstella commented Aug 22, 2024

Some more SSA stuff to remove.

@ljstella ljstella self-assigned this Aug 23, 2024
@ljstella
Copy link
Contributor Author

Only sections left appear to be in release_notes.py - not 100% that those have a replacement just yet.

@ljstella ljstella marked this pull request as ready for review September 12, 2024 17:07
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I independently looked for more SSA bits in the code as well and, other than what @ljstella pointed out in his comment did not find any.
Looks good to me, thank you for the cleanup!

@pyth0n1c
Copy link
Contributor

Only sections left appear to be in release_notes.py - not 100% that those have a replacement just yet.

I agree. I saw these in there and we chatted offline about the one additional reference and it was removed 👍

@pyth0n1c pyth0n1c merged commit c1dd3ca into main Sep 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants