Enable acs deploy + appinspect warnings #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to enable ACS deployment. reduce non-blocking warnings thrown by appinspect api by updating some automatically generated app files.
to default.meta
in contentctl.py. Print out what is returned from ACS, even on success.
pyth0n1c
commented
Aug 22, 2024
There was a problem hiding this comment.
Everything below the comment no longer exists as a conf file - should these all be removed from the default.meta file? I think that is probably the case.
There was a problem hiding this comment.
We should also evaluate the contents of the distsearch.conf file.
patel-bhavin
approved these changes
Nov 6, 2024
|
Tested the build locally, works good! This generates all the files for ESCU from contentctl except : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes adds acs_deploy functionality to contentctl 4.x.
It is mostly a port and cleanup of how it was implemented in contentctl 3.x.
It also addresses some warnings that were present in Cloud Appinspect results.
Note that in order to get these changes in a pre-exisiting contentctl app, you may need to
update files in your app_template folder.
These changes have been made to app.conf, content-version.conf, and default.meta.