Skip to content

Conversation

@hetangmodi-crest
Copy link
Contributor

@hetangmodi-crest hetangmodi-crest commented Apr 16, 2025

Issue number: ADDON-76780

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

This PR includes the generation of the searchbnf.conf file for the custom search command.

User experience

After defining a valid configuration for the custom search command in globalConfig.json, the searchbnf.conf file will be generated.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

ucc_dir=ucc_dir,
addon_name=ta_name,
)
assert searchbnf_conf.searchbnf_info == []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the last test but TBH I am not sure a test like that is needed. I mean, the last test probably covers the whole class and on the other hand a test like this one here, will fail when the parameter is renamed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case when the searchAssistant isn't provided in globalConfig, we wouldn't be able to test for the file content as it won't be present as the file itself wouldn't be created, and hence, in the test case, I didn't make the generate() call as we know the file won't be generated. I'll take it up in the other PR for updating tests.

@hetangmodi-crest hetangmodi-crest merged commit 863d5a0 into feat/add-validations-for-csc May 9, 2025
92 checks passed
@hetangmodi-crest hetangmodi-crest deleted the feat/generation-of-searchbnf.conf branch May 9, 2025 10:04
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants