-
Notifications
You must be signed in to change notification settings - Fork 35
feat: generation of searchbnf.conf
#1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generation of searchbnf.conf
#1695
Conversation
splunk_add_on_ucc_framework/generators/conf_files/create_searchbnf_conf.py
Outdated
Show resolved
Hide resolved
| ucc_dir=ucc_dir, | ||
| addon_name=ta_name, | ||
| ) | ||
| assert searchbnf_conf.searchbnf_info == [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the last test but TBH I am not sure a test like that is needed. I mean, the last test probably covers the whole class and on the other hand a test like this one here, will fail when the parameter is renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case when the searchAssistant isn't provided in globalConfig, we wouldn't be able to test for the file content as it won't be present as the file itself wouldn't be created, and hence, in the test case, I didn't make the generate() call as we know the file won't be generated. I'll take it up in the other PR for updating tests.
863d5a0
into
feat/add-validations-for-csc
Issue number: ADDON-76780
PR Type
What kind of change does this PR introduce?
Summary
Changes
This PR includes the generation of the
searchbnf.conffile for the custom search command.User experience
After defining a valid configuration for the custom search command in
globalConfig.json, thesearchbnf.conffile will be generated.Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear