Skip to content

Conversation

@hetangmodi-crest
Copy link
Contributor

Issue number:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Due to the changes implemented in PR #1669, globalConfig is no longer optional. As a result, the self.global_config conditions are being removed from the generators.

User experience

No change in user experience.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@hetangmodi-crest hetangmodi-crest added the refactor Issue to track refactor work label Apr 1, 2025
@hetangmodi-crest hetangmodi-crest self-assigned this Apr 1, 2025
@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review April 1, 2025 09:09
@hetangmodi-crest hetangmodi-crest requested a review from a team as a code owner April 1, 2025 09:09
@artemrys artemrys enabled auto-merge (squash) April 1, 2025 09:55
@artemrys artemrys disabled auto-merge April 1, 2025 09:55
@artemrys artemrys changed the title refactor: update generators by removing self.global_config refactor: globalConfig file is now required during the build process Apr 1, 2025
@artemrys artemrys enabled auto-merge (squash) April 1, 2025 09:55
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Code Coverage 🎉

Type PR Develop Change Status
Line Coverage 87.04% 87.09% 0.05% 🔴 Decreased
Branch Coverage 80.34% 80.34% 0.00% 🟢 Increased

@artemrys artemrys merged commit 62403f7 into develop Apr 1, 2025
93 of 94 checks passed
@artemrys artemrys deleted the chore/update-generators branch April 1, 2025 10:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor Issue to track refactor work size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants