feat: introduce GlobalConfig.from_app_manifest#1662
Merged
artemrys merged 1 commit intochore/gc-updatefrom Mar 27, 2025
Merged
Conversation
hetangmodi-crest
approved these changes
Mar 27, 2025
| app_manifest_correct | ||
| ) | ||
|
|
||
| assert expected_global_config == global_config |
Contributor
There was a problem hiding this comment.
I think instead of adding comparison method in source code only for tests, we could have a helper method that does the same job as we do in __eq__() method. Thoughts?
Member
Author
There was a problem hiding this comment.
Yeah, I could do that but I like keeping such logic in the class itself.
If I would be writing a test to compare 2 objects - I assume
this object has eq method implemented.
Contributor
|
Should we also update |
kkedziak-splunk
approved these changes
Mar 27, 2025
Member
Author
Good catch, I'll update the coverage in the "chore/gc-update" branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-78488
PR Type
What kind of change does this PR introduce?
Summary
Changes
This feature allows UCC to initialize a
GlobalConfigfromapp.manifestfile. This will be later used to create aGlobalConfigif there is no such exists which enables UCC to support.conf-only add-ons in a better way.User experience
N/A
Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear