Skip to content

Conversation

@artemrys
Copy link
Member

Issue number: N/A

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Further simplification of GlobalConfig class, this PR removes original_path parameter from the GlobalConfig's constructor.

This would allow us to simply integrate from_app_conf_and_app_manifest to allow all TAs to have globalConfig.

User experience

N/A

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@artemrys artemrys marked this pull request as ready for review March 26, 2025 14:33
@artemrys artemrys requested a review from a team as a code owner March 26, 2025 14:33
@github-actions
Copy link

Code Coverage 🎉

Type PR Develop Change Status
Line Coverage 86.95% 86.91% 0.04% 🟢 Increased
Branch Coverage 80.27% 80.12% 0.15% 🟢 Increased

@artemrys artemrys merged commit ebcadef into develop Mar 26, 2025
93 of 94 checks passed
@artemrys artemrys deleted the refactor/global-config-original-path branch March 26, 2025 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants