Support for Polkadot v0.8.28#50
Merged
splix merged 2 commits intosplix:masterfrom Apr 24, 2021
blockchain:master
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
============================================
+ Coverage 86.91% 87.04% +0.13%
- Complexity 892 911 +19
============================================
Files 115 118 +3
Lines 2973 3034 +61
Branches 430 438 +8
============================================
+ Hits 2584 2641 +57
Misses 278 278
- Partials 111 115 +4 Continue to review full report at Codecov.
|
Owner
|
@pablojorge sorry, totally missed the Pull Request. Just checked it, everything looks good, and I'm going to merge it now. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for two changes introduced in v0.8.28 (https://github.com/paritytech/polkadot/releases/tag/v0.8.28):
A new
MultiAddressclass that takes the place and wraps the original Address is introduced. TheBalanceTransferandExtrinsicclasses now contain a reference to aMultiAddress, and for backward compatibility, we keep setters that accept a plainAddressinstance.