Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tracker object methods #6

Merged
merged 2 commits into from
Jul 23, 2013
Merged

added tracker object methods #6

merged 2 commits into from
Jul 23, 2013

Conversation

jpoday
Copy link
Contributor

@jpoday jpoday commented Jun 24, 2013

Hello Andrew,

I had a need for some additional tracker methods, and I saw you had a note that said you needed more options. I added this functionality. The input uses a hash of method names with corresponding values. All three types of object arguments are supported (String, Boolean, and no arguments). I also updated the Readme with the new functionality.

I added a test, which passes, but I was getting an failure on the custom variables test as it was checked out. It can't seem to find the session variable in the tests. I chalked this up to a test issue and I didn't resolve it. I'm a bit of a noob and it would probably take me forever to figure out.

I also removed the "_trackPageLoadTime()" from the generated javascript, as Google says the method is deprecated.

This is only my second pull request ever, so feel free to tear me up. Like I said, I'm a bit of a noob.

Thanks,
-Joe

@rceee
Copy link

rceee commented Jul 22, 2013

Is this project still active/compatible? Just started looking into it, and wondered too if "_trackPageLoadTime()" needs to be removed or if the js needs to otherwise be updated.

@andrew
Copy link
Member

andrew commented Jul 23, 2013

Sorry, not sure how this one slipped through the cracks of my inbox, will merge it in now.

Thanks!

andrew added a commit that referenced this pull request Jul 23, 2013
@andrew andrew merged commit f78252d into splitrb:master Jul 23, 2013
@rceee
Copy link

rceee commented Jul 23, 2013

Cool, thanks man :)

@jpoday jpoday deleted the add-tracker-object-methods branch July 27, 2013 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants