Update mPDF to 8.0.17 #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some known issues with PHP 8, like exporting PDF files with SVG gradients, that was already fixed on newer mPDF versions from 8.0 branch.
Klap-in
reviewed
Nov 7, 2023
| @@ -939,7 +942,7 @@ class Mpdf implements \Psr\Log\LoggerAwareInterface | |||
| private $remoteContentFetcher; | |||
|
|
|||
| /** | |||
| * @var ImageProcessor | |||
| * @var \Mpdf\Image\ImageProcessor | |||
There was a problem hiding this comment.
on line 13 the import is removed
use \dokuwiki\plugin\dw2pdf\DokuImageProcessorDecorator as ImageProcessor;As this is only Phpdocs, it is fine for me to not change the ImageProcessor here.
Klap-in
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Good idea to offer this in-between version. Then we can offer a more smooth update path for the dw2pdf plugin to at least php8.1.
This version we can then be refered for everybody who then still needs to stay at php7.4 yet. With that available, I have also less hesitations for updating dw2pdf to the most recent versions of mpdf in a next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As migrating to mPDF 8.1.* didn't seem viable yet (#476), there's some known issues with PHP 8, like exporting PDF files with SVG gradients (mpdf/mpdf@5b19fb6), that was already fixed on latest mPDF stable from 8.0 branch (8.0.17).