Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BitPackedArray should store packed values in Buffer #850

Closed
a10y opened this issue Sep 17, 2024 · 0 comments · Fixed by #862
Closed

BitPackedArray should store packed values in Buffer #850

a10y opened this issue Sep 17, 2024 · 0 comments · Fixed by #862

Comments

@a10y
Copy link
Contributor

a10y commented Sep 17, 2024

Currently it's stored in PrimitiveArray, but the semantics are wrong: the PType is the PType for the unpacked array
@a10y a10y mentioned this issue Sep 18, 2024
Merged
@a10y a10y closed this as completed in #862 Sep 18, 2024
a10y added a commit that referenced this issue Sep 18, 2024
@a10y @lwwmanning
feat: use Buffer for BitPackedArray (#862)
f9d5878 
Fixes #850

---------

Co-authored-by: Will Manning <[email protected]>
lwwmanning added a commit that referenced this issue Sep 18, 2024
@a10y @lwwmanning
feat: use Buffer for BitPackedArray (#862)
a30b9fa 
Fixes #850

---------

Co-authored-by: Will Manning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Buffer for BitPackedArray spiraldb/vortex
1 participant
@a10y