This repository has been archived by the owner on Jul 10, 2021. It is now read-only.
Update index.md #1957
Open
Update index.md #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary punctuation marks and words Removed finger pointing icon for consistency Broke a sentence into two since it seems like two different thoughts
dorbin
reviewed
Jul 22, 2020
| @@ -44,8 +44,9 @@ endpoint depends on how you've configured your [Spinnaker | |||
| endpoints](/setup/security) -- if you're running on a different endpoint, for | |||
| example `https://api.spinnaker-prod.net`, that'll be shown instead. | |||
|
|
|||
| Keeping track of that endpoint as `$ENDPOINT` (it will depend on where | |||
| Spinnaker is installed), save that pipeline, and run: | |||
| Keeping track of that endpoint as `$ENDPOINT` will depend on where | |||
There was a problem hiding this comment.
Maybe just:
"Save that pipeline and run:
[command, including $ENDPOINT]
Where $ENDPOINT is the URL for the endpoint, which depends on where Spinnaker is installed."
Or something like that?
There was a problem hiding this comment.
These would work better as imperative verbs in numbered steps, but you'd have to do that to the entire article.
This paragraph here is the third step in this section.
dorbin
reviewed
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary punctuation marks and words
Removed finger pointing icon for consistency
Broke a sentence into two since it seems like two different thoughts