chore(publishing): upgrade artifact registry jar #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also widened the default timeout for polling for imports based on recent builds timing out. There is some intertwining of dependencies between what the GCS lib and the artifact registry are using so I had to upgrade both.
dbyron-sf
reviewed
Nov 18, 2022
| @@ -174,7 +174,7 @@ private Operation importDebToArtifactRegistry(BlobId blobId) throws GeneralSecur | |||
|
|
|||
| Stopwatch timer = Stopwatch.createStarted(); | |||
| while (!operationIsDone(operation) && !operationTimedOut(timer)) { | |||
| Thread.sleep(1000); | |||
| Thread.sleep(30000); | |||
There was a problem hiding this comment.
Part of me wants this to be smaller/configurable, but part of me is happy to reduce the log spam during publishing.
dbyron-sf
approved these changes
Nov 18, 2022
|
Thank you @chris-h-phillips !! |
dbyron-sf
added a commit
to dbyron-sf/fiat
that referenced
this pull request
Nov 18, 2022
…d add --stacktrace (spinnaker#988)" This reverts commit 7885764. since spinnaker/spinnaker-gradle-project#185 has a fix
dbyron-sf
added a commit
to dbyron-sf/fiat
that referenced
this pull request
Nov 18, 2022
…innaker#987)" This reverts commit 9ad1d22. since spinnaker/spinnaker-gradle-project#185 has a fix
dbyron-sf
added a commit
to spinnaker/fiat
that referenced
this pull request
Nov 18, 2022
* Revert "chore(build): set timeout for apt publishing to 10 minutes and add --stacktrace (#988)" This reverts commit 7885764. since spinnaker/spinnaker-gradle-project#185 has a fix * Revert "chore(build): set timeout for apt publishing to 5 minutes (#987)" This reverts commit 9ad1d22. since spinnaker/spinnaker-gradle-project#185 has a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also widened the default timeout for polling for imports based on recent builds timing out. There is some intertwining of dependencies between what the GCS lib and the artifact registry are using so I had to upgrade both.