fix(orca-clouddriver): Fix exception in mapping of trafficManagement when null #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-dragon
approved these changes
Feb 21, 2025
|
We're now 2 PRs deep with no tests....This needs to change. Any chance you can add one here? |
Yeah sure, will do until Monday. Lets hold 1.37.x for this fix though |
Agreed. Thank you! |
christosarvanitis
force-pushed
the
fixTrafficManagementMapping
branch
from
2eb3309 to
a3b367c
Compare
dbyron-sf
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mapping exception when trafficManagement is not defined in the Deploy stage definition.
Exception:
Resulted from changes in #4823