Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(igor/google): Support GCB cancellation from Spinnaker UI. #4827

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

himanhsugusain
Copy link
Contributor

@himanhsugusain himanhsugusain commented Jan 26, 2025

Description

Add support for stopping GCB (google cloud build) from Spinnaker.
The current GCB controller in Igor only supports Cancellation of builds global pool under the project, so does this change.

Testing

Local Spinnaker Instance testing with GCB.

# Test 
~/personal/orca master % ./gradlew :orca-igor:test

> Task :orca-igor:compileGroovy
warning: Implicitly compiled files were not subject to annotation processing.
  Use -implicit to specify a policy for implicit compilation.
Note: /Users/himanshu.gusain/personal/orca/orca-igor/src/main/java/com/netflix/spinnaker/orca/igor/tasks/StartGoogleCloudBuildTask.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning

BUILD SUCCESSFUL in 6s
25 actionable tasks: 3 executed, 22 up-to-date

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@himanhsugusain himanhsugusain changed the title feat(provider/google): Support private worker pool in gcb CI feat(igor/google): Support private worker pool in gcb CI Jan 26, 2025
@himanhsugusain himanhsugusain changed the title feat(igor/google): Support private worker pool in gcb CI feat(igor/google): Support GCB cancellation from Spinnaker UI. Jan 26, 2025
Add support for stopping google cloud build from Spinnaker.
The current GCB controller in Igor only supports Cancellation of builds `global` pool under the `project`, so does this change.
@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Jan 28, 2025
@mergify mergify bot added the auto merged Merged automatically by a bot label Jan 28, 2025
@mergify mergify bot merged commit 0e62406 into spinnaker:master Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.37
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants