test(sql): Add extra test for pipelineRef feature flag #4760
Conversation
| @@ -332,6 +337,120 @@ public void testExcludeSpinnakerAccountsFromPipeline() throws Exception { | |||
| assertThat(pipelineExecution.getAuthentication().getAllowedAccounts()).isEqualTo(Set.of()); | |||
| } | |||
|
|
|||
| @DisplayName( | |||
| "when pipelineRef.enabled: true, the object mapper can deserialize the PipelineTrigger into PipelineRefTrigger") | |||
There was a problem hiding this comment.
Isn't the operation here about converting from pipeline config to pipeline execution? It would help me if the description focused on this more than the implementation details.
Maybe this isn't 100% of what's happening since triggers come in from manual execution, and from parent pipeline executing children. But, these triggers never have full on execution contexts, do they? I mean, the pipeline in question hasn't run yet, right? If that's true, wouldn't we expect the same behavior whether pipelineRef.enabled is true or not?
There was a problem hiding this comment.
In the ExecutionLauncher the pipeline hasn't run yet. The purpose of the ExecutionLauncher is take a pipeline config and parse it into a execution context then store it using SqlExecutionRepository.
The main idea of my new tests is that even with the customTrigger configured in the objectMapper the ExecutionLauncher can start a new execution. I just include an assert to validate that the customTrigger is being use as well but the same behavior is kept.
I will change the description on the test to avoid implementation details
I added more tests in executionLaucherTest regarding PipelineRef feature include as part of #4749