This repository was archived by the owner on Dec 20, 2025. It is now read-only.
feat(moniker): Move OperationDescription from clouddriver to kork #1199
Merged
mergify[bot] merged 1 commit intospinnaker:masterfrom Jul 30, 2024
Merged
Conversation
… add an overloaded applyMoniker method with the description parameter Added a new overloaded applyMoniker method to the Namer interface with an OperationDescription parameter. The new method defaults to calling the existing applyMoniker method without the description. Moved the OperationDescription from clouddriver's com.netflix.spinnaker.clouddriver.orchestration to kork-moniker's com.netflix.spinnaker.orchestration.
kunalsharma05
force-pushed
the
skip-spec-template-labels
branch
from
6bf28cb to
36cebde
Compare
dbyron-sf
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and add an overloaded applyMoniker method with the description parameter.
Added a new overloaded applyMoniker method to the Namer interface with an OperationDescription parameter. The new method defaults to calling the existing applyMoniker method without the description. Moved the OperationDescription from clouddriver's com.netflix.spinnaker.clouddriver.orchestration to kork-moniker's com.netflix.spinnaker.orchestration.
First used in #1199