Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deck): Features should be singular #80

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix(deck): Features should be singular #80

merged 1 commit into from
Jun 8, 2020

Conversation

ezimanyi
Copy link
Contributor

@ezimanyi ezimanyi commented Jun 8, 2020

The deck config expects feature flags to be under the singular 'feature'. (This is a bit confusing because Halyard used plural 'features' in its config, but it ended up singular in the generated config.)

The deck config expects feature flags to be under the singular
'feature'. (This is a bit confusing because Halyard used plural
'features' in its config, but it ended up singular in the
generated config.)
@ezimanyi ezimanyi requested a review from maggieneterval June 8, 2020 20:16
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1️⃣ 🎉

@maggieneterval maggieneterval merged commit 4fd919b into spinnaker:master Jun 8, 2020
@ezimanyi ezimanyi deleted the fix-deck branch June 8, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants