chore(protoc): Bump protoc and protoc-gen-go #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets us to 3.12.x of protoc, which adds support for optional fields. We said we'd revisit in a few weeks (a few weeks ago) and make a final decision about how to handle this. By pulling in a version of protoc that has support for optional fields (behind a flag) it will be easier to play around with this and see the generated code than if we also had to bump protoc. Also bump protoc-gen-go while we're generating this code. As usual, neither dependency bump changes the generated code, other than the versioned comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us to 3.12.x of protoc, which adds support for optional fields. We said we'd revisit in a few weeks (a few weeks ago) and make a final decision about how to handle this. By pulling in a version of protoc that has support for optional fields (behind a flag) it will be easier to play around with this and see the generated code than if we also had to bump protoc.
Also bump protoc-gen-go while we're generating this code.
As usual, neither dependency bump changes the generated code, other than the versioned comment.