Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): consistent package structure for tests #44

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

maggieneterval
Copy link
Contributor

Reorganizes package parse_hal:

  • Splits each hal_to_{service} method into its own file.
  • Splits each hal_to_{service} tests into corresponding file, in parse_hal_test package within parse_hal directory.
  • Potentially controversially, moves "end to end" tests that read from YAML into each hal_to_{service}_test file as well, since they are in fact testing the conversion of a hal config to a service config (just from YAML rather than Go structs).
  • Moves test YAML into testdata file as this directory name seems to be a Go convention (it is ignored when you run go build).

Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 💅 📦 🏗️ 💯

@ezimanyi ezimanyi added the ready to merge Reviewed and ready for merge label Apr 29, 2020
@ezimanyi
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2020

Command refresh: success

@mergify mergify bot merged commit bdd3985 into spinnaker:master Apr 29, 2020
@mergify mergify bot added the auto merged label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged ready to merge Reviewed and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants