feat(front50): Add azs and oracle persistent stores #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also renames the GCS message to GcsPersistentStore to be more in line with how we've named other things. It also removes the top-level persistentStore field, and requires each persistent store to be marked as enabled or disabled (with exactly one being enabled) to match what front50 expects. While this is a slight change, hopefully it will be easy to configure as the kleat config will only require the single one that's being used to be in the config (unlike Halyard which will add fields for everything). I didn't add tests here, as we're about to do some refactoring and potentially will clean up the tests. I'll add tests on this when finishing up the rest of the persistent stores.
|
I'm liberally renumbering proto fields for now because we don't actually have any existing messages to support (and it of course doesn't affect the YAML). At some point we should stop doing that, but that time is not now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also renames the GCS message to GcsPersistentStore to be more in line with how we've named other things.
It also removes the top-level persistentStore field, and requires each persistent store to be marked as enabled or disabled (with exactly one being enabled) to match what front50 expects. While this is a slight change, hopefully it will be easy to configure as the kleat config will only require the single one that's being used to be in the config (unlike Halyard which will add fields for everything).
I didn't add tests here, as we're about to do some refactoring and potentially will clean up the tests. I'll add tests on this when finishing up the rest of the persistent stores.