feat(docs): document poor performance of sortTagsByDate flag #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in spinnaker/spinnaker#5538, the
sortTagsByDateflag has prohibitive performance implications for registries with tens or hundreds of thousands of tags. However, we learned from conversations in Slack and at the Kubernetes SIG that users with smaller registries still find this flag valuable. Let's at least add a warning to the documentation, and in the future we can revisit either removing the flag or improving the performance of its implementation if the Docker V2 API ever supports fetching tags chronologically (or even batching requests for individual tags to get their creation date).Corresponding Halyard PR: spinnaker/halyard#1639