Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(packages): move non-internal packages to /pkg #26

Merged
merged 1 commit into from
Apr 9, 2020
Merged

refactor(packages): move non-internal packages to /pkg #26

merged 1 commit into from
Apr 9, 2020

Conversation

maggieneterval
Copy link
Contributor

In addition to the autogenerated Go client, the operator eventually plans to consume Kleat's

  • methods for transforming a halconfig into each service config
  • method for validating a halconfig

Let's move those packages from /internal to a new /pkg directory, which is the standard for library code.

@maggieneterval maggieneterval requested a review from ezimanyi as a code owner April 9, 2020 15:50
ezimanyi
ezimanyi approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚚 📦 💯 🎈

@ezimanyi ezimanyi added the ready to merge Reviewed and ready for merge label Apr 9, 2020
@mergify mergify bot merged commit 2858643 into spinnaker:master Apr 9, 2020
@mergify mergify bot added the auto merged label Apr 9, 2020
@maggieneterval maggieneterval deleted the pkg branch April 9, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Reviewed and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maggieneterval @ezimanyi