Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws): Adding property externalId to AWS account config for assuming roles. #146

Merged
merged 3 commits into from
Oct 5, 2020
Merged

feat(aws): Adding property externalId to AWS account config for assuming roles. #146

merged 3 commits into from
Oct 5, 2020

Conversation

ivanphdz
Copy link
Contributor

@ivanphdz ivanphdz commented Oct 5, 2020 •
edited
Loading

ezimanyi
ezimanyi approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ezimanyi ezimanyi added the ready to merge Reviewed and ready for merge label Oct 5, 2020
@mergify mergify bot merged commit 8b668ce into spinnaker:master Oct 5, 2020
@mergify mergify bot added the auto merged label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

@maggieneterval maggieneterval Awaiting requested review from maggieneterval

Assignees
No one assigned
Labels
auto merged ready to merge Reviewed and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanphdz @ezimanyi