feat(authn/saml): New optional SAML parameter for signing messages #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimanyi
reviewed
Jul 7, 2020
|
|
||
| // Digest algorithms to sign SAML messages. | ||
| enum SignatureDigest { | ||
| // Digest algorithm SHA1 (default). |
There was a problem hiding this comment.
In general we're recommending that all enums UNSPECIFIED = 0 as their first (default) entry. There are more details here, but the main reason is that enums set to their default will be omitted from serialization. (So if a user explicitly sets the signature digest to SHA1, it won't be included in the output YAML if that's the default.)
In this case, since Gate uses SHA1 as the default it wouldn't matter, because there would be no difference to gate between signatureDigest: SHA1 and omitting signatureDigest. But then this creates a coupling between kleat and gate where the correctness here depends on the defaulting in gate (and if we ever change the default in gate this will break).
ezimanyi
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Gate PR: spinnaker/gate#1269
Related Halyard PR: spinnaker/halyard#1741