Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Bump dependencies #107

Merged
merged 3 commits into from
Jun 24, 2020
Merged

chore(core): Bump dependencies #107

merged 3 commits into from
Jun 24, 2020

Conversation

ezimanyi
Copy link
Contributor

  • chore(core): Bump dependencies

    go get -u ./...

  • chore(proto): Bump protoc-gen-go

    Also while updating the docker file, revert to using the official release of protoc-gen-doc as we don't need optional support anymore. This way we're no longer depending on the version in my fork.

  • refactor(proto): Remove wrapper package

    google.golang.org/protobuf v1.25.0 adds new helper functions that obviate the need for the ones that we wrote. Let's remove our layer of indirection and just call the new functions.

ezimanyi added 3 commits June 24, 2020 12:34
Also while updating the docker file, revert to using the official
release of protoc-gen-doc as we don't need optional support anymore.
This way we're no longer depending on the version in my fork.
google.golang.org/protobuf v1.25.0 adds new helper functions that
obviate the need for the ones that we wrote. Let's remove our
layer of indirection and just call the new functions.
@ezimanyi ezimanyi requested a review from maggieneterval June 24, 2020 16:36
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 🎁 ✅ 💯 🏅

@maggieneterval maggieneterval added the ready to merge Reviewed and ready for merge label Jun 24, 2020
@mergify mergify bot merged commit 0c7699f into spinnaker:master Jun 24, 2020
@mergify mergify bot added the auto merged label Jun 24, 2020
@ezimanyi ezimanyi deleted the bump-deps branch June 24, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged ready to merge Reviewed and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants