Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkg): Add snake_case json_names to snake_case monitoring protos #101

Merged
merged 1 commit into from
Jun 17, 2020
Merged

fix(pkg): Add snake_case json_names to snake_case monitoring protos #101

merged 1 commit into from
Jun 17, 2020
+54 −53

Conversation

maggieneterval
Copy link
Contributor

fix(pkg): Add snake_case json_names to snake_case monitoring protos

@maggieneterval maggieneterval requested a review from ezimanyi as a code owner June 17, 2020 18:05
ezimanyi
ezimanyi approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍 🔡 🔠 💯

@ezimanyi ezimanyi added the ready to merge Reviewed and ready for merge label Jun 17, 2020
@mergify mergify bot merged commit 8e94fac into spinnaker:master Jun 17, 2020
@mergify mergify bot added the auto merged label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi

Assignees
No one assigned
Labels
auto merged ready to merge Reviewed and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maggieneterval @ezimanyi