feat(spin): Adds new command to install spin CLI. #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
reviewed
Aug 2, 2018
| @@ -0,0 +1,24 @@ | |||
| package com.netflix.spinnaker.halyard.cli.command.v1; | |||
|
|
||
| @RestController | ||
| @RequestMapping("/v1/spin") | ||
| public class SpinController { |
There was a problem hiding this comment.
Should this be "spin" or "install" controller? Esp. if we added the "install" command to fetch other tools in the future
There was a problem hiding this comment.
The command structure is hal spin <>. We came up with three commands yesterday for things we'd need to support for spin: install (latest) install --version and uninstall|remove. Do we want to change that to hal install|uninstall spin?
There was a problem hiding this comment.
No I think your approach is better, hal install... might confuse people
lwander
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs latest version only. Will introduce commands to install from a BOM and from a spin version soon.