Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(install): configure command-completion on install #996

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

lwander
Copy link
Member

@lwander lwander commented Aug 2, 2018

The new install path was not generating the command-completion scripts.

fyi @ttomsu who found this

@lwander lwander requested review from jtk54 and ttomsu August 2, 2018 19:14
@@ -274,6 +278,43 @@ function install_java() {
fi
}

function configure_bash_completion() {
local yes
echo ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, for newline

@lwander lwander merged commit d0608b5 into spinnaker:master Aug 2, 2018
@lwander lwander deleted the command-completion branch August 2, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants