Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(halyard): Add merging default env with serviceSettings env. #995

Merged
merged 1 commit into from
Aug 2, 2018
Merged

fix(halyard): Add merging default env with serviceSettings env. #995

merged 1 commit into from
Aug 2, 2018

Conversation

eromanova
Copy link
Contributor

lwander
lwander approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@lwander lwander merged commit a9ba4fa into spinnaker:master Aug 2, 2018
@ttomsu ttomsu mentioned this pull request Sep 6, 2018
Closed
@eromanova eromanova deleted the mergeEnvironment branch September 13, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwander lwander lwander approved these changes

Assignees
No one assigned
Labels
target-release/1.6
Projects
None yet
Milestone
No milestone
3 participants
@eromanova @lwander @spinnakerbot