-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider/kubernetes): adding changes for aws eks #981
Conversation
Related documentation updates --> spinnaker/spinnaker.github.io#884 |
Dockerfile
Outdated
@@ -22,6 +22,12 @@ RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/${KUBECTL | |||
chmod +x ./kubectl && \ | |||
mv ./kubectl /usr/local/bin/kubectl | |||
|
|||
RUN curl -o heptio-authenticator-aws https://amazon-eks.s3-us-west-2.amazonaws.com/1.10.3/2018-06-05/bin/linux/amd64/heptio-authenticator-aws && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to fetch the latest release like we do with kubectl above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the authenticator is pinned down to a specific version of kubectl + folder structure in S3 is pinned down to a specific release date, we cannot get the latest, however, good point, will parameterize this so that the authenticator url will not require change for future upgrades
I think the clouddriver pod will need this build change as well. |
Sorry one last thing -- can you make this change here too? https://github.com/spinnaker/halyard/blob/master/Dockerfile.local I think this is the one we build in our nightlies. |
Thanks! Will merge & rebuild the |
Hi - there seems to be a typo in the URL that is used to download the heptio-authenticator-aws binary. Currently, the URL resolves to The correct URL should be The difference is the "v" in front of the Kubectl version number; the "v" in the KUBECTL_RELEASE string must be deleted to form the correct URL for heptio-authenticator-aws. (Perhaps the Heptio folks changed their path convention?) Edit: I've submitted pull request #986 to fix this. |
No description provided.