-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(halyard): Added hal shutdown command. #980
Conversation
|
||
@Getter(AccessLevel.PUBLIC) | ||
private String description = "Shutdown the halyard daemon."; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
@Override | ||
protected void executeThis() { | ||
Daemon.shutdown(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we print the shutdown message if it fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already prints if halyard isn't up and running:
$ hal shutdown
! ERROR Failed to connect to localhost/0:0:0:0:0:0:0:1:8064
? Is your daemon running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you check to see that the response from the daemon is the expected shutdown message, isn't it possible that the daemon sends something else when the shutdown fails?
No description provided.