Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docker-registry account regex validator #976

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

nthh
Copy link
Contributor

@nthh nthh commented Jun 15, 2018

Relevant error in clouddriver:

due to violations [ConstraintViolationImpl{interpolatedMessage='must match "^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$"', propertyPath=metadata.name, rootBeanClass
=class io.fabric8.kubernetes.api.model.Secret, messageTemplate='{io.fabric8.kubernetes.api.model.Pattern.message}'}]

Fixes #2397

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

e8329fa: Updated docker-registry account regex validator

Relevant error in clouddriver: due to violations [ConstraintViolationImpl{interpolatedMessage='must match "^a-z0-9?(.a-z0-9?)*$"', propertyPath=metadata.name, rootBeanClass
=class io.fabric8.kubernetes.api.model.Secret, messageTemplate='{io.fabric8.kubernetes.api.model.Pattern.message}'}]

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@nthh nthh force-pushed the patch-1 branch 2 times, most recently from 33a4032 to b51525b Compare June 15, 2018 03:46
Relevant error in clouddriver: due to violations [ConstraintViolationImpl{interpolatedMessage='must match "^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$"', propertyPath=metadata.name, rootBeanClass
=class io.fabric8.kubernetes.api.model.Secret, messageTemplate='{io.fabric8.kubernetes.api.model.Pattern.message}'}]
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lwander lwander merged commit 995017b into spinnaker:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants