Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): Fix permissions of files installed by Halyard #971

Merged
merged 1 commit into from
Jun 14, 2018
Merged

fix(install): Fix permissions of files installed by Halyard #971

merged 1 commit into from
Jun 14, 2018

Conversation

ezimanyi
Copy link
Contributor

No description provided.

@ezimanyi
Copy link
Contributor Author

ezimanyi commented Jun 14, 2018

@lwander : I want to make sure I understand why we're doing chown $HAL_USER:halyard /opt/halyard which confused me at first. It looks like this is necessary to allow the pid file to be written into /opt/halyard...but given that (for typical umask) the permissions on /opt/halyard will by 755, the halyard group won't actually have permission to create the pid file so you have to run Halyard as the $HAL_USER. We could fix this by setting the permissions to 775 but it also makes me wonder if it might be better to have the pid file in /var/run as is more typical (and then completely avoid needing to chown the /opt/halyard directory). This point is somewhat outside the scope of this PR (and I just ignored it for the change here) but it came to mind as I was reading this.

@lwander
Copy link
Member

lwander commented Jun 14, 2018

+1 to moving the PID file to /var/run -- we'll just need to do it carefully to support migrating from one pid file to another.

@lwander lwander merged commit 55b6d4b into spinnaker:master Jun 14, 2018
@ezimanyi ezimanyi deleted the fix-install-permissions branch June 14, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants