Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): s/osx/macos #970

Merged
merged 1 commit into from
Jun 13, 2018
Merged

chore(release): s/osx/macos #970

merged 1 commit into from
Jun 13, 2018

Conversation

lwander
Copy link
Member

@lwander lwander commented Jun 13, 2018

No description provided.

@lwander lwander requested a review from jtk54 June 13, 2018 19:02
@lwander
Copy link
Member Author

lwander commented Jun 13, 2018

FYI @dorbin

@lwander lwander mentioned this pull request Jun 13, 2018
Closed
jtk54
jtk54 approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this consistent with the release tooling now or are there changes there as well?

@lwander
Copy link
Member Author

lwander commented Jun 13, 2018

Yup, no other changes needed

Still need to run a build to make this consistent

@lwander lwander merged commit 8287f23 into spinnaker:master Jun 13, 2018
@lwander lwander deleted the rename-to-macos branch June 13, 2018 19:18
@ezimanyi ezimanyi mentioned this pull request Jun 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtk54 jtk54 jtk54 approved these changes

Assignees
No one assigned
Labels
target-release/1.3
Projects
None yet
Milestone
No milestone
3 participants
@lwander @jtk54 @spinnakerbot