Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci/wercker): Add wercker ci to halyard #960

Merged
1 commit merged into from
Jul 25, 2018

Conversation

guoyongzhang
Copy link
Contributor

Added wercker as a ci provider.

Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM -- but doesn't this require support in Igor as well?

@@ -0,0 +1,72 @@
/*
* Copyright (c) 2017, 2018, Oracle Corporation and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 2017 correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Oracle policy, yes.

@Parameter(
names = "--organizations",
variableArity = true,
description = WerckerCommandProperties.ORGANIZATIONS_DESCRIPTION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation here doesn't match the rest of the file

@guoyongzhang
Copy link
Contributor Author

There will be more PRs for wercker support in deck, igor, orca, etc. But, this PR doesn't depend on them.

@lwander
Copy link
Member

lwander commented Jun 1, 2018

Sounds good. Let's merge this when the support is in the rest of Spinnaker. Otherwise the autogenerated docs will lead users to believe werker is already supported.

Also, I would recommend talking to @ezimanyi either on a separate issue or on Slack as to how to best proceed on new CI integrations.

@guoyongzhang guoyongzhang force-pushed the wrkr-379 branch 2 times, most recently from b262eff to 3993b4c Compare June 6, 2018 17:35
@desagar desagar force-pushed the wrkr-379 branch 2 times, most recently from 3c4785a to 90a6bf9 Compare June 28, 2018 16:16
@desagar
Copy link

desagar commented Jul 10, 2018

PRs have been put up for the Wercker CI and Wercker pipeline stage feature implementation. Related PRs:

spinnaker/igor#297
spinnaker/deck#5519
spinnaker/echo#295
spinnaker/gate#574
spinnaker/orca#2313

@markxnelson

@lwander Would you be able to help us get this PR and the other ones related to Wercker CI integration reviewed?

@ghost
Copy link

ghost commented Jul 25, 2018

Support's been merged in to Spinnaker now so I'm proceeding with merge to Halyard.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants