-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci/wercker): Add wercker ci to halyard #960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM -- but doesn't this require support in Igor as well?
@@ -0,0 +1,72 @@ | |||
/* | |||
* Copyright (c) 2017, 2018, Oracle Corporation and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 2017 correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Oracle policy, yes.
@Parameter( | ||
names = "--organizations", | ||
variableArity = true, | ||
description = WerckerCommandProperties.ORGANIZATIONS_DESCRIPTION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation here doesn't match the rest of the file
There will be more PRs for wercker support in deck, igor, orca, etc. But, this PR doesn't depend on them. |
Sounds good. Let's merge this when the support is in the rest of Spinnaker. Otherwise the autogenerated docs will lead users to believe werker is already supported. Also, I would recommend talking to @ezimanyi either on a separate issue or on Slack as to how to best proceed on new CI integrations. |
b262eff
to
3993b4c
Compare
3c4785a
to
90a6bf9
Compare
PRs have been put up for the Wercker CI and Wercker pipeline stage feature implementation. Related PRs: spinnaker/igor#297 @lwander Would you be able to help us get this PR and the other ones related to Wercker CI integration reviewed? |
Support's been merged in to Spinnaker now so I'm proceeding with merge to Halyard. |
Added wercker as a ci provider.