fix(deck/auth): Add the correct security env variables in deck. #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttomsu
approved these changes
May 30, 2018
| .setEnabled(true); | ||
| } | ||
|
|
||
| private void setEnv(String var) { |
| .setEnabled(true); | ||
| } | ||
|
|
||
| private void setEnv(String var) { | ||
| setStartCommand(String.join("\n", "export " + var + "=true", getStartCommand())); |
There was a problem hiding this comment.
Genuine question - do we need to export the var? This SO post appears to use some bash magic that I've seen @ewiseblatt use with the python scripts.
There was a problem hiding this comment.
We probably don't, but in this case it doesn't matter since the whole command is encapsulated in start.sh and we don't need to make it a one-liner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.